Fix lutron caseta occupancy sensors by bdraco · Pull Request #71309 · home-assistant/core

bdraco · 2022-05-04T19:54:19Z

Proposed change

Fix lutron caseta occupancy sensors

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes Caseta Occupancy Sensors Fail #71308
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

probot-home-assistant · 2022-05-04T19:54:29Z

Hey there @swails, mind taking a look at this pull request as it has been labeled with an integration (lutron_caseta) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

swails

Well I had to cancel my original review as you already implemented the changes I was going to suggest 😆

chrisaljoudi · 2022-05-04T20:26:12Z

They don't have a 'model' either, which is read unconditionally in LutronCasetaDevice init:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 249, in _async_setup_platform
    await asyncio.shield(task)
  File "/usr/src/homeassistant/homeassistant/components/lutron_caseta/binary_sensor.py", line 34, in async_setup_entry
    entity = LutronOccupancySensor(occupancy_group, bridge, bridge_device)
  File "/usr/src/homeassistant/homeassistant/components/lutron_caseta/binary_sensor.py", line 45, in __init__
    super().__init__(device, bridge, bridge_device)
  File "/usr/src/homeassistant/homeassistant/components/lutron_caseta/__init__.py", line 313, in __init__
    model=f"{device['model']} ({device['type']})",
KeyError: 'model'

bdraco · 2022-05-04T20:31:34Z

They don't have a 'model' either, which is read unconditionally in LutronCasetaDevice init:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 249, in _async_setup_platform
    await asyncio.shield(task)
  File "/usr/src/homeassistant/homeassistant/components/lutron_caseta/binary_sensor.py", line 34, in async_setup_entry
    entity = LutronOccupancySensor(occupancy_group, bridge, bridge_device)
  File "/usr/src/homeassistant/homeassistant/components/lutron_caseta/binary_sensor.py", line 45, in __init__
    super().__init__(device, bridge, bridge_device)
  File "/usr/src/homeassistant/homeassistant/components/lutron_caseta/__init__.py", line 313, in __init__
    model=f"{device['model']} ({device['type']})",
KeyError: 'model'

I was just about to post the same thing after reading though the diagnostics.

bdraco · 2022-05-04T20:31:52Z

So the unique ids here aren't actually unique if you have multiple bridges, but thats another problem

This reverts commit 69d19dc.

bdraco · 2022-05-04T20:35:18Z

I'm going to fix this for now and migrate the unique ids in 2022.6

bdraco · 2022-05-04T20:37:36Z

homeassistant/components/lutron_caseta/binary_sensor.py

@@ -65,16 +85,6 @@ def unique_id(self):
        """Return a unique identifier."""
        return f"occupancygroup_{self.device_id}"


This is not actually unique if you have multiple bridges. We need to prefix it with the bridge id as well since it is unique to the bridge.

We can migrate them in 2022.6 though as its better to fix this now instead of adding risk

bdraco · 2022-05-04T20:38:46Z

@chrisaljoudi Can you test with the latest push?

bdraco · 2022-05-04T20:46:29Z

I also uploaded it as a custom_component for easy testing
#71308 (comment)

chrisaljoudi · 2022-05-04T20:54:45Z

@bdraco the custom component is missing the added check in LutronCasetaDevice init (present in the PR here), but I added that and it works.

bdraco · 2022-05-04T20:57:10Z

@bdraco the custom component is missing the the added check in LutronCasetaDevice init (present in the PR here), but I added that and it works.

Thanks. I forgot to push the __init__.py to the custom component. Now done in ca6b28113a924fc2ccd6afcd29f18fb0c3fbafc2

bdraco · 2022-05-04T21:03:38Z

@chrisaljoudi Thanks for testing.

I'm going to need to migrate the unique ids so they are actually unique in 2022.6. Do you mind if I ping you to test that PR in a few days?

Since I don't actually have any of these I'm going to order up a LRF2-OWLB-P-WH so I can test the migration code but it would be better to get a test from someone who uses them in production.

chrisaljoudi · 2022-05-04T21:08:26Z

@bdraco absolutely happy to! Have 3 bridges in use.

frenck · 2022-05-05T07:32:03Z

This one is for the next patch release, right? (Asking as it's not tagged for the milestone...)

* Fix lutron_caseta occupancy sensors * Fix lutron_caseta occupancy sensors * Make as service since its a group * merge * Revert "merge" This reverts commit 69d19dc. * model and type not present

bdraco added 2 commits May 4, 2022 14:42

Fix lutron_caseta occupancy sensors

f046b53

Fix lutron_caseta occupancy sensors

2b07c6f

homeassistant added the cla-signed label May 4, 2022

probot-home-assistant bot added bugfix integration: lutron_caseta small-pr PRs with less than 30 lines. by-code-owner labels May 4, 2022

Make as service since its a group

5b4bfde

bdraco mentioned this pull request May 4, 2022

Fix occ sensors in Caseta #71311

Closed

22 tasks

merge

69d19dc

swails approved these changes May 4, 2022

View reviewed changes

bdraco added 2 commits May 4, 2022 16:32

Revert "merge"

12d420d

This reverts commit 69d19dc.

model and type not present

c25b5ab

bdraco commented May 4, 2022

View reviewed changes

bdraco marked this pull request as ready for review May 4, 2022 20:57

thecode approved these changes May 4, 2022

View reviewed changes

balloob merged commit d67f19f into home-assistant:dev May 5, 2022

bdraco added this to the 2022.5.1 milestone May 5, 2022

thecode mentioned this pull request May 5, 2022

The problem of Lutron Caséta Occupancy sensor with core 5.0 #71371

Closed

balloob added the cherry-picked label May 5, 2022

balloob mentioned this pull request May 5, 2022

2022.5.1 #71376

Merged

github-actions bot locked and limited conversation to collaborators May 6, 2022

		@@ -65,16 +85,6 @@ def unique_id(self):
		"""Return a unique identifier."""
		return f"occupancygroup_{self.device_id}"

Uh oh!

Conversation

bdraco commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

probot-home-assistant bot commented May 4, 2022

Uh oh!

swails left a comment

Choose a reason for hiding this comment

Uh oh!

chrisaljoudi commented May 4, 2022

Uh oh!

bdraco commented May 4, 2022

Uh oh!

bdraco commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bdraco commented May 4, 2022

Uh oh!

bdraco May 4, 2022

Choose a reason for hiding this comment

Uh oh!

bdraco May 4, 2022

Choose a reason for hiding this comment

Uh oh!

bdraco commented May 4, 2022

Uh oh!

bdraco commented May 4, 2022

Uh oh!

chrisaljoudi commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bdraco commented May 4, 2022

Uh oh!

bdraco commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisaljoudi commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frenck commented May 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bdraco commented May 4, 2022 •

edited

Loading

bdraco commented May 4, 2022 •

edited

Loading

chrisaljoudi commented May 4, 2022 •

edited

Loading

bdraco commented May 4, 2022 •

edited

Loading

chrisaljoudi commented May 4, 2022 •

edited

Loading